Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/513#discussion_r95593265
--- Diff:
utils/groovy/src/main/java/org/apache/brooklyn/util/groovy/GroovyJavaMethods.java
---
@@ -75,6 +76,20 @@
}
}
+ /**
+ * Alternative implementation of {@link
ScriptBytecodeAdapter#isCase(Object, Object)}<br>
+ * Stripped down to work only for caseExpression of type
<code>java.lang.Class</code>.<br>
--- End diff --
I wondered about that as well - that was my initial reaction. However, I'm
fine with doing it like this for two reasons.
First, we can change most callers to instead use `JavaGroovyEquivalents` to
avoid calling groovy code at all. Second, groovy allows some weird stuff with
meta-programming, so I think it's safest to call the real Groovy code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
