Github user geomacy commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/529#discussion_r97353258
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java
---
@@ -625,6 +630,30 @@ public MachineLocation obtain(Map<?,?> flags) throws
NoMachinesAvailableExceptio
}
}
+ protected ManagementAddressResolveOptions
getManagementAddressResolveOptions(
+ NodeMetadata node, ConfigBag setup, Optional<HostAndPort>
sshHostAndPortOverride, Optional<LoginCredentials> userCredentials) {
+ boolean waitForSshable =
!"false".equalsIgnoreCase(setup.get(WAIT_FOR_SSHABLE));
--- End diff --
Could push the knowledge about the configuration keys into the constructor
of the class itself, and just make this
```java
protected ManagementAddressResolveOptions
getManagementAddressResolveOptions(
NodeMetadata x, ConfigBag setup, Optional<HostAndPort> x,
Optional<LoginCredentials> x) {
return new ManagementAddressResolveOptions(setup)
.hostAndPortOverride(sshHostAndPortOverride)
.initialCredentials(node.getCredentials())
.userCredentials(userCredentials));
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
