Github user geomacy commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/529#discussion_r97510372
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java
---
@@ -2610,24 +2525,32 @@ public boolean apply(@Nullable WinRmMachineLocation
machine) {
return credsSuccessful.get();
}
- protected LoginCredentials waitForSshable(final ComputeService
computeService, final NodeMetadata node, HostAndPort managementHostAndPort,
ConfigBag setup) {
- LoginCredentials nodeCreds = node.getCredentials();
+ protected LoginCredentials waitForSshableGuessCredentials(final
ComputeService computeService, final NodeMetadata node, HostAndPort
managementHostAndPort, ConfigBag setup) {
--- End diff --
This new method isn't being called, but the newly deprecated method at line
2564 still is, at JcloudsLocation.java:811. I guess you meant here to replace
the calls to `waitForSshable(final ComputeService computeService, final
NodeMetadata node, HostAndPort hostAndPort, Iterable<LoginCredentials>
credentialsToTry, ConfigBag setup)` with calls to
`waitForSshableGuessCredentials`. But shouldn't
`waitForSshableGuessCredentials` be calling `waitForSshable( HostAndPort
hostAndPort, Iterable<LoginCredentials> credentialsToTry, ConfigBag setup)` at
line 2533 rather than the deprecated five param version?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
