Github user neykov commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/529#discussion_r97966691
  
    --- Diff: 
core/src/main/java/org/apache/brooklyn/util/core/task/BasicTask.java ---
    @@ -377,7 +377,9 @@ public T getUnchecked() {
         public synchronized void blockUntilStarted() {
             blockUntilStarted(null);
         }
    -    
    +
    +    // TODO: This should log a message if timeout is null and the method 
blocks for an unreasonably long time -
    +    // it probably means someone called .get() and forgot to submit the 
task.
    --- End diff --
    
    Should differentiate between not queued to a parent task (because the user 
forgot the submit it) and not yet submitted to an executor because a previous 
task failed which is a valid case.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to