Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/529#discussion_r97983346
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java
---
@@ -625,6 +630,32 @@ public MachineLocation obtain(Map<?,?> flags) throws
NoMachinesAvailableExceptio
}
}
+ protected ManagementAddressResolveOptions
getManagementAddressResolveOptions(
+ NodeMetadata node, ConfigBag setup, Optional<HostAndPort>
sshHostAndPortOverride, Optional<LoginCredentials> userCredentials) {
+ boolean waitForSshable =
!"false".equalsIgnoreCase(setup.get(WAIT_FOR_SSHABLE));
+ boolean waitForWinRmable =
!"false".equalsIgnoreCase(setup.get(WAIT_FOR_WINRM_AVAILABLE));
+ boolean usePortForwarding = setup.get(USE_PORT_FORWARDING);
+ boolean skipJcloudsSshing =
Boolean.FALSE.equals(setup.get(USE_JCLOUDS_SSH_INIT)) || usePortForwarding;
+ boolean windows = isWindows(node, setup);
+ boolean waitForConnectable = windows ? waitForWinRmable :
waitForSshable;
+ String pollForFirstReachable =
setup.get(POLL_FOR_FIRST_REACHABLE_ADDRESS);
+ boolean pollEnabled =
!"false".equalsIgnoreCase(pollForFirstReachable);
+ Duration pollTimeout = "true".equals(pollForFirstReachable) ?
Duration.FIVE_MINUTES : Duration.of(pollForFirstReachable);
+ Predicate<? super HostAndPort> reachablePredicate =
getReachableAddressesPredicate(setup);
+ return new ManagementAddressResolveOptions()
+ .expectReachable(waitForConnectable)
+ .hostAndPortOverride(sshHostAndPortOverride)
+ .initialCredentials(node.getCredentials())
+ .isWindows(windows)
+ .pollForFirstReachableAddress(pollEnabled)
+ .pollTimeout(pollTimeout)
+ .propagatePollForReachableFailure(true)
+ .reachableAddressPredicate(reachablePredicate)
+ .skipJcloudsSshing(skipJcloudsSshing)
+ .userCredentials(userCredentials)
+ .waitForSshable(waitForSshable);
--- End diff --
Can use `expectReachable` instead. But suggest renaming it to
`waitForConnectable` to keep the convention.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
