Github user m4rkmckenna commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/516#discussion_r101255832
  
    --- Diff: karaf/features/src/main/feature/feature.xml ---
    @@ -260,7 +260,7 @@
                 https://github.com/square/okhttp/pull/2246
             -->
             <!-- TODO use ServiceMix bundle for okhttp when dependency on okio 
is fixed there -->
    -        <bundle 
dependency="true">wrap:mvn:com.squareup.okhttp/okhttp/2.2.0$Import-Package=org.apache.http.*;resolution:=optional,android.util.*;resolution:=optional,okio;version=%27[1.2.0,1.3.0)%27,*</bundle>
    +        <bundle 
dependency="true">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.okhttp/2.2.0_2</bundle>
    --- End diff --
    
    Can you explain your reasoning for this ... I remember there being an issue 
with the servicemix wrapped version
    
    Also version should be parameterised 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to