Github user aledsage commented on the issue:

    https://github.com/apache/brooklyn-server/pull/516
  
    @googlielmo (cc @m4rkmckenna) given Marks' comment about seeing value in 
this, then I'm fine with us merging it and then iterating on it to add more 
assertions (as we find time to do that). That feels better than having the PR 
sitting around for longer. Does that sound sensible to you @m4rkmckenna?
    
    @googlielmo can you squash your commits please, and ensure there is a nice 
description on the commit(s)? (We want the commits descriptions to be 
understandable when glancing through the history of Brooklyn commits, where we 
can't easily tell which PR they were in; commit messages like "wip" don't tell 
us what it's for).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to