Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/480#discussion_r103455566
  
    --- Diff: 
core/src/main/java/org/apache/brooklyn/util/core/task/ValueResolver.java ---
    @@ -512,6 +559,24 @@ public Object call() throws Exception {
             }
         }
     
    +    protected Maybe<T> execImmediate(ExecutionContext exec, Object 
immediateSupplierOrImmediateTask) {
    +        Maybe<T> result;
    +        try {
    +            result = exec.getImmediately(immediateSupplierOrImmediateTask);
    +        } catch (ImmediateSupplier.ImmediateUnsupportedException e) {
    +            return null;
    +        }
    +        // let 
InterruptingImmediateSupplier.InterruptingImmediateSupplierNotSupportedForObject
 
    +        // bet thrown, and caller who cares will catch that to know it can 
continue
    --- End diff --
    
    typo: `be thrown`.
    And could add javadoc:
    ```
        /**
         * @throws 
InterruptingImmediateSupplier.InterruptingImmediateSupplierNotSupportedForObject
 if ...
         */
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to