Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/480#discussion_r103494117
--- Diff:
camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/methods/DslComponent.java
---
@@ -554,15 +562,55 @@ protected String resolveKeyName(boolean immediately) {
.displayName("retrieving config for "+keyName)
.tag(BrooklynTaskTags.TRANSIENT_TASK_TAG)
.dynamic(false)
- .body(new Callable<Object>() {
- @Override
- public Object call() throws Exception {
- Entity targetEntity = component.get();
- String keyNameS = resolveKeyName(true);
- ConfigKey<?> key =
targetEntity.getEntityType().getConfigKey(keyNameS);
- return targetEntity.getConfig(key != null ?
key : ConfigKeys.newConfigKey(Object.class, keyNameS));
- }})
- .build();
+ .body(newCallable(false)).build();
+ }
+
+ private Callable<Object> newCallable(final boolean immediate) {
--- End diff --
yeah it's ugly; at least it's private. have renamed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
