Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/591
LGTM.
In jclouds, it always sets allocatePTY when using sshj:
https://github.com/jclouds/jclouds/blob/rel/jclouds-2.0.0/drivers/sshj/src/main/java/org/jclouds/sshj/SshjSshClient.java#L438
In contrast, brooklyn only sets it if configured to do so:
https://github.com/apache/brooklyn-server/blob/rel/apache-brooklyn-0.10.0/core/src/main/java/org/apache/brooklyn/util/core/internal/ssh/sshj/SshjTool.java#L837-L839
Brooklyn defaults this to not allocatePTY:
https://github.com/apache/brooklyn-server/blob/rel/apache-brooklyn-0.10.0/core/src/main/java/org/apache/brooklyn/util/core/internal/ssh/SshTool.java#L75
Brooklyn will then by default execute a command to disable requiretty:
https://github.com/apache/brooklyn-server/blob/rel/apache-brooklyn-0.10.0/locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java#L904-L915
That behaviour is configurable via
https://github.com/apache/brooklyn-server/blob/rel/apache-brooklyn-0.10.0/locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocationConfig.java#L179-L188
Making this change just means we do the same as jclouds already does. This
change will only affect us if we've set `useJcloudsSshInit: false`, and then
only for the initial createUser command execution.
We have much more thoroughly tested the jclouds behaviour across many
clouds, because `useJcloudsSshInit` defaults to true.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
