Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/591
@bostko I've tested this on aws and softlayer, on centos 6 & 7, and ubuntu
16, 14, 12 and 10. I'll add some more live tests for those in a separate PR
later.
I don't think we should rely on `DONT_REQUIRE_TTY_FOR_SUDO`: that controls
whether we execute an extra command so that we disable requiretty in the
`/etc/sudoers` file! It might be set to false. Note that the extra command also
sets `SshTool.PROP_ALLOCATE_PTY` to true (as @ygy is doing here).
`SshMachineLocation.SSH_CONFIG_GIVEN_TO_PROPS` feels overkill here. This is
an unusual use-case: it only affects the arg passed to the single createUser
command, and then only if one has set `useJcloudsSshInit: false`. I think that
a user would sensibly expect a config option like `SSH_CONFIG_GIVEN_TO_PROPS`
to be used more widely. It's unclear to me where else we'd want to use it,
given one can pass through other config for the SshMachineLocation to use
already.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
