Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/612#discussion_r108630701
--- Diff:
camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/creation/BrooklynEntityDecorationResolver.java
---
@@ -230,4 +237,51 @@ protected void addDecorationFromJsonMap(Map<?, ?>
decorationJson, List<SpecParam
throw new IllegalStateException("Not called");
}
}
+
+ public static class TagsResolver extends
BrooklynEntityDecorationResolver<Iterable<Object>> {
+ protected TagsResolver(BrooklynYamlTypeInstantiator.Factory
instantiator) {
+ super(instantiator);
+ }
+
+ @Override
+ public void decorate(EntitySpec<?> entitySpec, ConfigBag attrs,
Set<String> encounteredRegisteredTypeIds) {
+ if (getDecorationAttributeJsonValue(attrs) != null) {
--- End diff --
Minor personal preference: I'd store this as a variable rather than
evaluating it twice.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
