Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/612#discussion_r108633804
  
    --- Diff: 
camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/creation/BrooklynComponentTemplateResolver.java
 ---
    @@ -257,6 +257,7 @@ public boolean canResolve() {
             new 
BrooklynEntityDecorationResolver.EnricherSpecResolver(yamlLoader).decorate(spec,
 attrs, encounteredRegisteredTypeIds);
             new 
BrooklynEntityDecorationResolver.InitializerResolver(yamlLoader).decorate(spec, 
attrs, encounteredRegisteredTypeIds);
             new 
BrooklynEntityDecorationResolver.SpecParameterResolver(yamlLoader).decorate(spec,
 attrs, encounteredRegisteredTypeIds);
    +        new 
BrooklynEntityDecorationResolver.TagsResolver(yamlLoader).decorate(spec, attrs, 
encounteredRegisteredTypeIds);
    --- End diff --
    
    @tbouron what do you mean by a "first-class citizen" here? Do you mean are 
we right to be promoting it as a first-class citizen, or should we be promoting 
it more?
    
    It should be a first-class concept - it's not a part of config or anything 
like that. It needs to end up being added to the `EntitySpec` via 
`spec.tagsAdd(...)`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to