Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/617#discussion_r109357619
--- Diff:
api/src/main/java/org/apache/brooklyn/api/mgmt/ManagementContext.java ---
@@ -66,9 +67,20 @@
* In other words the value of {@link
Application#getManagementContext()#getManagementPlaneId()}
* will generally be constant (in contrast to {@link
#getManagementNodeId()}).
* <p>
- * This value should not be null unless the management context is a
non-functional
- * (non-deployment) instance. */
+ * Throws an {@link NullPointerException} if the value hasn't been
initialized yet. The value is set:
--- End diff --
Wonder whether we should leave this to return `null` when not initialised.
It's been useful to find instances of wrong (too early) usage but on the other
hand changes the method behaviour.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
