Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/617#discussion_r110364489
--- Diff:
core/src/main/java/org/apache/brooklyn/core/mgmt/rebind/PeriodicDeltaChangeListener.java
---
@@ -382,6 +401,8 @@ protected void persistNowInternal(boolean
alreadyHasMutex) {
if (!alreadyHasMutex) persistingMutex.acquire();
if (!isActive() && state != ListenerState.STOPPING) return;
+ updatePlaneIdIfTimedOut();
--- End diff --
Writes to the datastore are lossy. We'll just log failures and move on.
(Most) entities will get updated multiple times in their lifecycle so not a
huge deal. planeId does not get updated so if the first write fails it's not
available to the HA cluster at all. That's why I decided to periodically write
it to the datastore. Will add a comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
