Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/612#discussion_r109872011
--- Diff:
camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/creation/BrooklynEntityDecorationResolver.java
---
@@ -227,7 +234,54 @@ protected Object
getDecorationAttributeJsonValue(ConfigBag attrs) {
@Override
protected void addDecorationFromJsonMap(Map<?, ?> decorationJson,
List<SpecParameter<?>> decorations) {
- throw new IllegalStateException("Not called");
+ throw new
UnsupportedOperationException("SpecParameterResolver.addDecorationFromJsonMap
should never be called.");
+ }
+ }
+
+ public static class TagsResolver extends
BrooklynEntityDecorationResolver<Iterable<Object>> {
+ protected TagsResolver(BrooklynYamlTypeInstantiator.Factory
instantiator) {
+ super(instantiator);
+ }
+
+ @Override
+ public void decorate(EntitySpec<?> entitySpec, ConfigBag attrs,
Set<String> encounteredRegisteredTypeIds) {
+ if (getDecorationAttributeJsonValue(attrs) != null) {
+
entitySpec.tagsAdd((Iterable<Object>)getDecorationAttributeJsonValue(attrs));
+ }
+ }
+
+ @Override
+ protected String getDecorationKind() {
+ return "Brooklyn Tags";
+ }
+
+ @Override
+ protected Object getDecorationAttributeJsonValue(ConfigBag attrs) {
--- End diff --
As said earlier, I'd declare the return type as `Iterable<Object>` to avoid
the cast in the caller.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
