Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/612#discussion_r109870494
--- Diff:
core/src/main/java/org/apache/brooklyn/core/mgmt/BrooklynTags.java ---
@@ -108,6 +123,39 @@ public TraitsTag(List<Class<?>> interfaces) {
}
}
+ public static class CampBrooklynTag implements Serializable {
--- End diff --
I'm not convinced we want to wrap the user's tag in a `CampBrooklynTag`,
rather than just adding their tag directly. I'm guessing that things behave
very differently if you do `brooklyn.tags: ["hi"]` then the result is very
different from doing Java `entity.tags()addTag("hi")` - i.e. the latter has the
tag "hi", whereas the former has the tag of type "CampBrooklynTag" that wraps
the string "hi".
Other than being able to tell where the tag came from, what is the
advantage of using `CampBrooklynTag`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
