Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/799#discussion_r135761929
--- Diff:
core/src/main/java/org/apache/brooklyn/core/catalog/internal/BasicBrooklynCatalog.java
---
@@ -112,7 +112,7 @@
import com.google.common.collect.Maps;
/* TODO the complex tree-structured catalogs are only useful when we are
relying on those separate catalog classloaders
- * to isolate classpaths. with osgi everything is just put into the
"manual additions" catalog. */
+ * to isolate classpaths. with osgi everything is just put into the
"manual additions" catalog. Deprecate/remove this. */
--- End diff --
I'd prefer a "TODO" next to any comments like "Deprecate/remove this"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
