Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/799#discussion_r135825312
  
    --- Diff: 
camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/catalog/CatalogYamlEntityOsgiTypeRegistryTest.java
 ---
    @@ -36,15 +36,42 @@
         // use OSGi here
         @Override protected boolean disableOsgi() { return false; }
         
    -    // use type registry appraoch
    +    enum CatalogItemsInstallationMode { ADD_YAML_ITEMS_UNBUNDLED, 
BUNDLE_BUT_NOT_STARTED, USUAL_OSGI_WAY_AS_BUNDLE_WITH_DEFAULT_NAME, 
USUAL_OSGI_WAY_AS_ZIP_NO_MANIFEST_NAME_MAYBE_IN_BOM }
    --- End diff --
    
    was getting quite long wasn't it?  started out with short names then was 
refactored  :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to