Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/866#discussion_r146491921
--- Diff:
core/src/main/java/org/apache/brooklyn/core/catalog/internal/CatalogInitialization.java
---
@@ -528,8 +528,60 @@ private void startBundle(OsgiBundleInstallationResult
br) throws BundleException
}
}
+ private PersistedCatalogState
filterPersistedState(PersistedCatalogState persistedState, RebindLogger
rebindLogger) {
+ CatalogUpgrades catalogUpgrades =
findCatalogUpgrades(rebindLogger);
--- End diff --
feels like this information should be kept in memory not just grabbed for
this method. probably keep in `OsgiManager` or `BrooklynTypeRegistry` ? not
essential for this PR as i expect it will be needed for follow-on work but for
cleanliness we should avoid `findCatalogUpgrades` twice
---
