Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/866
looks good apart from comments above. good set of tests.
one other area i've wondered about is snapshot versions. what _is_ the
behaviour and what _should_ it be?
OT1H if i say `remove=foo:[1,2)` i'd expect `1.5-SNAPSHOT` to be removed,
and `remove=foo[0,2)` for `0.SNAPSHOT` to be removed, but `3-SNAPSHOT` not
removed in both cases. not sure what the behaviour should be fore `2-SNAPSHOT`
and `2-GA`, probably not removed. OTOH `*-SNAPSHOT` is less than `0` by
brooklyn version ordering so there is reason to expect that none are removed.
as far as use cases, i think most common will be to say `remove all 1.* but
not any 2.*` (suggested behaviour above). however that's very hard if we take
a strict semver ordering (where `2.X` is less than `2` but bigger than any
`1.*`) or a brooklyn ordering (where `*-SNAPSHOT` less than `0`). osgi
ordering might have the right properties -- i forget.
worth updating `versioning.md` docs to describe this. also need docs on
removing/upgrading but expect that will come once part two of this work,
upgrading types, is done.
---
