Github user geomacy commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/964#discussion_r191382020
  
    --- Diff: 
core/src/main/java/org/apache/brooklyn/core/mgmt/rebind/PeriodicDeltaChangeListener.java
 ---
    @@ -222,6 +223,7 @@ public PeriodicDeltaChangeListener(
             this.persistPoliciesEnabled = 
BrooklynFeatureEnablement.isEnabled(BrooklynFeatureEnablement.FEATURE_POLICY_PERSISTENCE_PROPERTY);
             this.persistEnrichersEnabled = 
BrooklynFeatureEnablement.isEnabled(BrooklynFeatureEnablement.FEATURE_ENRICHER_PERSISTENCE_PROPERTY);
             this.persistFeedsEnabled = 
BrooklynFeatureEnablement.isEnabled(BrooklynFeatureEnablement.FEATURE_FEED_PERSISTENCE_PROPERTY);
    +        this.persistReferencedObjectsEnabled = 
BrooklynFeatureEnablement.isEnabled(BrooklynFeatureEnablement.FEATURE_REFERENCED_OBJECTS_PERSISTENCE_PROPERTY);
    --- End diff --
    
    might be worth naming this `rePersistReferencedObjectsEnabled` as its 
behaviour is different from the flags above, isn't it - they disable 
persistence of feeds etc. entirely, whereas this just disables the periodic 
re-persistence.  See comment on 542 below.


---

Reply via email to