Github user geomacy commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/964#discussion_r191375050
  
    --- Diff: 
core/src/main/java/org/apache/brooklyn/core/mgmt/rebind/PeriodicDeltaChangeListener.java
 ---
    @@ -443,7 +450,9 @@ protected void persistNowInternal(boolean 
alreadyHasMutex) {
                             limitedCountString(prevDeltaCollector.entities), 
limitedCountString(prevDeltaCollector.locations), 
limitedCountString(prevDeltaCollector.policies), 
limitedCountString(prevDeltaCollector.enrichers), 
limitedCountString(prevDeltaCollector.catalogItems), 
limitedCountString(prevDeltaCollector.bundles), 
                             
limitedCountString(prevDeltaCollector.removedEntityIds), 
limitedCountString(prevDeltaCollector.removedLocationIds), 
limitedCountString(prevDeltaCollector.removedPolicyIds), 
limitedCountString(prevDeltaCollector.removedEnricherIds), 
limitedCountString(prevDeltaCollector.removedCatalogItemIds), 
limitedCountString(prevDeltaCollector.removedBundleIds)});
     
    -            addReferencedObjects(prevDeltaCollector);
    +            if (persistReferencedObjectsEnabled) {
    +                addReferencedObjects(prevDeltaCollector);
    +            }
     
                 if (LOG.isTraceEnabled()) LOG.trace("Checkpointing delta of 
memento with references: "
    --- End diff --
    
    Let's move this LOG into the `if` above


---

Reply via email to