tbouron commented on a change in pull request #125: Fix errors around locations
in composer
URL: https://github.com/apache/brooklyn-ui/pull/125#discussion_r260330607
##########
File path:
ui-modules/blueprint-composer/app/components/util/model/entity.model.js
##########
@@ -281,6 +282,13 @@ export class Entity {
*/
removeLocation() {
LOCATIONS.delete(this);
+ this.miscData.delete('locationName');
+ this.miscData.delete('locationIcon');
+
+ // this field provides a way for consumers to detect if the location
was explicitly removed;
+ // this can be useful to prevent default locations from being applied
+ this.miscData.set('locationRemoved', true);
Review comment:
I don't get what this is for, even with the comment. Can you explain the
use-case please?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
