tbouron commented on a change in pull request #125: Fix errors around locations
in composer
URL: https://github.com/apache/brooklyn-ui/pull/125#discussion_r260328844
##########
File path:
ui-modules/blueprint-composer/app/components/providers/blueprint-service.provider.js
##########
@@ -603,16 +616,24 @@ function BlueprintService($log, $q, $sce, paletteApi,
iconGenerator, dslService)
function populateLocationFromApiSuccess(entity, data) {
entity.clearIssues({group: 'location'});
- entity.location = data.symbolicName;
- entity.miscData.set('locationName', data.name);
- entity.miscData.set('locationIcon', data.iconUrl ||
iconGenerator(data.symbolicName));
+ entity.location = data.yamlHere || data.symbolicName;
Review comment:
`yamlHere` property feels odd. I would go for just `yaml` or `spec`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
