tbouron commented on a change in pull request #140: Icons on app inspector
URL: https://github.com/apache/brooklyn-ui/pull/140#discussion_r324550905
##########
File path: ui-modules/app-inspector/app/components/entity-tree/entity-node.html
##########
@@ -22,9 +22,12 @@
<brooklyn-status-icon value="{{entity.serviceState}}"
ng-if="entity.serviceState || entity.applicationId"></brooklyn-status-icon>
<i class="fa fa-2x fa-external-link" ng-if="!entity.serviceState
&& !entity.applicationId"></i>
<span>{{entity.name}}</span>
+ <span class="node-icon"><img ng-src="{{ iconUrl }}"/></span>
</a>
- <div class="entity-node-toggle" ng-if="entity.children.length > 0 ||
entity.members.length > 0" ng-click="onToggle($event)" >
+ <div class="entity-node-toggle-wrapper">
Review comment:
Why wrapping this into another `div`? This entire "row" (i.e. entity status,
entity name, icon and expand toggle) can be handled with flexbox which would be
cleaner and easier to implement, rather than doing it with unnecessary HTML
layout.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
