tbouron commented on a change in pull request #140: Icons on app inspector
URL: https://github.com/apache/brooklyn-ui/pull/140#discussion_r324554190
##########
File path: ui-modules/utils/icon-generator/icon-generator.js
##########
@@ -104,21 +117,49 @@ function IconGenerator(cache, background, margin, size) {
export function iconServiceProvider() {
return {
- $get: ['$q', '$http', 'iconGenerator', function ($q, $http,
iconGenerator) {
- return new IconService($q, $http, iconGenerator, new
SessionsStorageWrapper(CACHE_NAME));
+ $get: ['$q', '$http', 'iconGenerator', '$log', function ($q, $http,
iconGenerator, $log) {
+ return new IconService($q, $http, iconGenerator, $log, new
SessionsStorageWrapper(CACHE_NAME));
}]
}
}
-function IconService($q, $http, iconGenerator, cache) {
+function IconService($q, $http, iconGenerator, $log, cache) {
this.get = getIcon;
- function getIcon(id) {
+ function getIcon(entityOrTypeId, doNotAutogenerate) {
Review comment:
As far as I can see, the there is no called using the `doNotAutogenerate`.
It seems to be used only on the pipe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
