aledsage commented on a change in pull request #1052: Bump groovy-eclipse-batch
from 2.4.3-01 to 2.5.8-02
URL: https://github.com/apache/brooklyn-server/pull/1052#discussion_r354355446
##########
File path: pom.xml
##########
@@ -129,7 +129,7 @@
<!-- @deprecated since 0.11 -->
<httpclient.version>4.5.6</httpclient.version> <!-- kept for
compatibility in 0.11.0-SNAPSHOT, remove after -->
<commons-lang3.version>3.3.2</commons-lang3.version>
- <groovy.version>2.4.15</groovy.version> <!-- Version 2.4.7 supported
by
https://github.com/groovy/groovy-eclipse/wiki/Groovy-Eclipse-2.9.1-Release-Notes;
not sure what more recent will be -->
+ <groovy.version>2.5.8</groovy.version> <!-- Version 2.4.7 supported by
https://github.com/groovy/groovy-eclipse/wiki/Groovy-Eclipse-2.9.1-Release-Notes;
not sure what more recent will be -->
Review comment:
Can you change the comment to say which groovy-eclipse (as per my comment on
the PR previously).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
