aledsage commented on a change in pull request #1052: Bump groovy-eclipse-batch
from 2.4.3-01 to 2.5.8-02
URL: https://github.com/apache/brooklyn-server/pull/1052#discussion_r357728088
##########
File path: core/pom.xml
##########
@@ -119,7 +119,13 @@
<dependency>
<groupId>org.codehaus.groovy</groupId>
- <artifactId>groovy-all</artifactId>
+ <artifactId>groovy</artifactId>
Review comment:
Speaking to @kemitix ,
https://search.maven.org/artifact/org.codehaus.groovy/groovy-all/2.5.8/pom is
now just a pom. I suspect our bundle reference in karaf to `groovy-all` would
no longer work (i.e. it's broken in karaf with this PR's changes) as that isn't
a jar file.
We could replace that line in feature.xml with two lines: for `groovy` and
`groovy-xml`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
