ahgittin commented on a change in pull request #1171:
URL: https://github.com/apache/brooklyn-server/pull/1171#discussion_r631766404
##########
File path:
core/src/main/java/org/apache/brooklyn/core/config/external/vault/VaultExternalConfigSupplier.java
##########
@@ -84,18 +86,19 @@ public VaultExternalConfigSupplier(ManagementContext
managementContext, String n
this.version = -1; // satisfy the static analysis :)
errors.add("'kv-api-version' must be either 1 or 2");
}
- recoverTryCount = NumberUtils.toInt(config.get("recoverTryCount"),10);
+ recoverTryCount = NumberUtils.toInt(config.get("recoverTryCount"), 10);
mountPoint = config.get("mountPoint");
if (Strings.isBlank(mountPoint) && this.version == 2)
errors.add("missing configuration 'mountPoint'");
- if (!Strings.isBlank(mountPoint) && this.version == 1)
errors.add("'mountPoint' is only applicable when kv-api-version=2");
+ if (!Strings.isBlank(mountPoint) && this.version == 1)
+ errors.add("'mountPoint' is only applicable when
kv-api-version=2");
Review comment:
we're well in to the realm of personal preference here (and not worth
changing) but most people in the project prefer braces
```
if (x) {
errors.add(...);
}
```
for short things i and some people prefer one line
```
if (x) errors.add(...);
```
multi-line without braces (your change here) is not very common.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
