zan-mateusz commented on a change in pull request #1171:
URL: https://github.com/apache/brooklyn-server/pull/1171#discussion_r631773429
##########
File path:
core/src/main/java/org/apache/brooklyn/core/config/external/vault/VaultExternalConfigSupplier.java
##########
@@ -84,18 +86,19 @@ public VaultExternalConfigSupplier(ManagementContext
managementContext, String n
this.version = -1; // satisfy the static analysis :)
errors.add("'kv-api-version' must be either 1 or 2");
}
- recoverTryCount = NumberUtils.toInt(config.get("recoverTryCount"),10);
+ recoverTryCount = NumberUtils.toInt(config.get("recoverTryCount"), 10);
mountPoint = config.get("mountPoint");
if (Strings.isBlank(mountPoint) && this.version == 2)
errors.add("missing configuration 'mountPoint'");
- if (!Strings.isBlank(mountPoint) && this.version == 1)
errors.add("'mountPoint' is only applicable when kv-api-version=2");
+ if (!Strings.isBlank(mountPoint) && this.version == 1)
+ errors.add("'mountPoint' is only applicable when
kv-api-version=2");
Review comment:
thanks for the feedback, it was not actually me to make the change but
intelliJ and its formatter, I personally actually find multiple line with even
with no braces easier to read than a single line, but as mentioned this is
personal preference really :) I will keep that in mind for future, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
