algairim commented on a change in pull request #1184:
URL: https://github.com/apache/brooklyn-server/pull/1184#discussion_r669536725
##########
File path:
core/src/main/java/org/apache/brooklyn/core/mgmt/ha/HighAvailabilityManagerImpl.java
##########
@@ -1072,6 +1081,26 @@ private ManagementPlaneSyncRecord
loadManagementPlaneSyncRecordInternal(boolean
throw new IllegalStateException(message, lastException);
}
+ private ManagementPlaneSyncRecord
updateManagementPlaneSyncRecordWithLocalKnowledge(ManagementPlaneSyncRecord
result) {
Review comment:
I would add javadoc saying that this method re-assigns the value of the
supplied parameter. Otherwise, make it final if you prefer to return a new
value from this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
