algairim commented on a change in pull request #1184:
URL: https://github.com/apache/brooklyn-server/pull/1184#discussion_r669537927



##########
File path: 
core/src/main/java/org/apache/brooklyn/core/mgmt/ha/HighAvailabilityManagerImpl.java
##########
@@ -1004,6 +1019,15 @@ public ManagementPlaneSyncRecord 
loadManagementPlaneSyncRecord(boolean useLocalK
         return record; 
     }
 
+    private boolean updateLastManagementPlaneSyncRecordWithLocalKnowledge() {
+        if (lastSyncRecord != null) {
+            lastSyncRecord = 
updateManagementPlaneSyncRecordWithLocalKnowledge(lastSyncRecord);
+            return true;
+        } else {
+            return false;
+        }
+    }

Review comment:
       Do we need this method at all? Dose not look like return value is used 
anywhere.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brooklyn.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to