ahgittin commented on a change in pull request #263:
URL: https://github.com/apache/brooklyn-ui/pull/263#discussion_r683597921
##########
File path:
ui-modules/blueprint-composer/app/components/util/model/entity.model.js
##########
@@ -685,7 +685,17 @@ function addConfigKeyDefinition(param, overwrite,
skipUpdatesDuringBatch) {
let key = (param || {}).name;
if (!key) throw new Error("'name' field must be included when adding
parameter; was", param);
- allConfig[key] = Object.assign(allConfig[key] || {}, param, overwrite
? null : allConfig[key]);
+ let paramMapped = Object.assign({}, param);
Review comment:
slightly clearer and more efficient apart from (1) you've lost the
`overwrite` behaviour and (2) bringing in `get` obscures behaviour for those
not familiar with `_.get` -- but the benefit is so slight it isn't worth the
effort of testing it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
