jathanasiou commented on a change in pull request #263:
URL: https://github.com/apache/brooklyn-ui/pull/263#discussion_r683600477



##########
File path: 
ui-modules/blueprint-composer/app/components/spec-editor/spec-editor.template.html
##########
@@ -323,7 +323,7 @@ <h4>No matching parameters</h4>
           <div ng-if="model.miscData.get('config').length === 0">
             <h4>No configuration</h4>
             <p class="buttons">
-                <button class="btn btn-sm btn-success" 
ng-click="specEditor.addConfigKey(state.config.search)" 
ng-if="state.config.search">
+                <button class="btn btn-sm btn-success" 
ng-click="specEditor.addConfigKey(state.config.search)" 
ng-if="state.config.search && state.config.search!=''">

Review comment:
       Sounds like an angular 1 bug. I saw some mentions online of how `ng-if` 
evaluates expressions so maybe we're victims of that.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to