Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/31#discussion_r14378770
  
    --- Diff: 
core/src/main/java/brooklyn/catalog/internal/CatalogItemDtoAbstract.java ---
    @@ -1,14 +1,18 @@
     package brooklyn.catalog.internal;
     
    +import javax.annotation.Nonnull;
    +
     import brooklyn.catalog.CatalogItem;
     
     public abstract class CatalogItemDtoAbstract<T> implements CatalogItem<T> {
    -    
    +
         String id;
         String type;
         String name;
         String description;
         String iconUrl;
    +    String version;
    --- End diff --
    
    Longer term, would be nice to have a Version class that wraps the string - 
it would support comparisons etc.
    Ideally we'd also use some third part library that correctly implements 
semantic versioning.
    Alternatively, if we used OSGi versioning (different semantics as I recall, 
such as `1.20 < 1.3`) then maybe Felix has an appropriate comparator.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to