Github user sjcorbett commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/31#discussion_r14398853
  
    --- Diff: 
core/src/main/java/brooklyn/catalog/internal/CatalogItemDtoAbstract.java ---
    @@ -1,14 +1,18 @@
     package brooklyn.catalog.internal;
     
    +import javax.annotation.Nonnull;
    +
     import brooklyn.catalog.CatalogItem;
     
     public abstract class CatalogItemDtoAbstract<T> implements CatalogItem<T> {
    -    
    +
         String id;
         String type;
         String name;
         String description;
         String iconUrl;
    +    String version;
    --- End diff --
    
    If we go with OSGi versioning we can use Felix's implementation of 
[org.osgi.framework.Version](http://www.osgi.org/javadoc/r5/core/org/osgi/framework/Version.html)
 class, which implements `Comparable<Version>`. There's also a `VersionRange` 
class.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to