Github user Nakomis commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/43#issuecomment-48368383
Regarding the status, I've addressed @*grkvlt <https://github.com/grkvlt>'s
comments, and it should be good to go*
As a more general question, should PRs be squashed into one commit? It
doesn't seem to be done for other PRs. If so, should it be done by the
committer - allowing them to review the changes commit-by-commit before
merging. In the case of this particular PR, aswel as the size, there's also
the fact that if there's an issue with the headers (in the wrong place etc)
it's likely to be an issue for all files of that type, so the ability to
revert a single commit (they're organized by file type) would be useful
On 8 July 2014 17:31, Richard Downer <[email protected]> wrote:
> @Nakomis <https://github.com/Nakomis> @grkvlt <https://github.com/grkvlt>
> what's the latest on this PR? Could we get it merged before end of day
> tomorrow? There's some paperwork hinging on it that I would very much like
> to complete before I go on vacation!
>
> â
> Reply to this email directly or view it on GitHub
>
<https://github.com/apache/incubator-brooklyn/pull/43#issuecomment-48364369>
> .
>
--
Martin Harris
Lead Software Engineer
Cloudsoft Corporation Ltd
www.cloudsoftcorp.com
Mobile: +44 (0)7989 047-855
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
