Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/43#issuecomment-48369250
@Nakomis, PRs don't necessarily have to be squashed down into one commit -
in fact that's probably a bad idea, most PRs would have "steps on the way"
between the start state and the end state and it's useful to see the
intermediate steps.
Where there's been several review steps where the contributor has added
several commits of the form "changes in response to code review" I'd request
that some commit-squashing would be done. If there's only a single commit like
that I might let it pass; if there's several I would request it.
The committer could probably do that, but there's two issues with that.
Firstly it's really up to the contributor to provide a clean, well-presented
patch to the committer; secondly, if the committer is changing the commits it's
likely to change the "Author" tags in the commits, and therefore risks losing
the contributor's name from the official history record, and as a matter of
principle we ensure that all changes are correctly attributed to the person who
made them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
