Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/75#discussion_r15104316
  
    --- Diff: usage/rest-api/src/main/java/brooklyn/rest/api/EffectorApi.java 
---
    @@ -80,7 +81,7 @@ public Response invoke(
           
           @ApiParam(name = "parameters", value = "Effector parameters (as key 
value pairs)", required = false)
           @Valid 
    -      Map<String, String> parameters
    +      Map<String, Object> parameters
    --- End diff --
    
    Preference for `Map<String, ? extends Object>` so can be more easily 
called. Not particularly important here as main usage is REST api.
    
    However, I think it's possible to use the EffectorApi with some library 
goodness to provide a client java api that turns its calls into REST 
request/response. Do we have that out of interest?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to