Github user sjcorbett commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/75#discussion_r15106908
  
    --- Diff: usage/rest-api/src/main/java/brooklyn/rest/api/EffectorApi.java 
---
    @@ -80,7 +81,7 @@ public Response invoke(
           
           @ApiParam(name = "parameters", value = "Effector parameters (as key 
value pairs)", required = false)
           @Valid 
    -      Map<String, String> parameters
    +      Map<String, Object> parameters
    --- End diff --
    
    Or maybe not. Changing the signature to `Map<String, ? extends Object>` 
results in Jersey warning:
    ```
    WARNING: The following warnings have been detected with resource and/or 
provider classes:
      WARNING: Parameter 5 of type java.util.Map<java.lang.String, ?> from 
public abstract javax.ws.rs.core.Response 
brooklyn.rest.api.EffectorApi.invoke(java.lang.String,java.lang.String,java.lang.String,java.lang.String,java.util.Map<java.lang.String,
 ?>) is not resolvable to a concrete type
    ```
    And the test added to ApplicationResourceTest fails too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to