Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/83#discussion_r15466028
  
    --- Diff: core/src/main/java/brooklyn/entity/group/DynamicClusterImpl.java 
---
    @@ -257,7 +259,12 @@ public void start(Collection<? extends Location> 
locsO) {
                 int initialSize = getConfig(INITIAL_SIZE).intValue();
                 int initialQuorumSize = getInitialQuorumSize();
     
    -            resize(initialSize);
    +            try {
    +                resize(initialSize);
    +            } catch (Exception e) {
    +                Exceptions.propagateIfFatal(e);
    +                // ignore problems here; we extract them below
    --- End diff --
    
    Should log.debug, just in case the exception doesn't make itself into a 
`Tasks.children()` error for whatever reason? Losing an exception is much worse 
than a duplicate.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to