Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/83#discussion_r15518502
--- Diff:
software/webapp/src/main/java/brooklyn/entity/webapp/DynamicWebAppClusterImpl.java
---
@@ -41,6 +67,9 @@
*/
public class DynamicWebAppClusterImpl extends DynamicClusterImpl
implements DynamicWebAppCluster {
+ private static final Logger log =
LoggerFactory.getLogger(DynamicWebAppClusterImpl.class);
+ private static final FilenameToWebContextMapper
filenameToWebContextMapper = new FilenameToWebContextMapper();
--- End diff --
why `static`? I'd go for `private final`, even though it could be static
given it is stateless. No reason to make it a constant that I can see. If it is
left as a constant, the variable name should be in capital letters.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
