Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/83#discussion_r15519963
--- Diff:
utils/common/src/main/java/brooklyn/util/exceptions/ReferenceWithError.java ---
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package brooklyn.util.exceptions;
+
+import javax.annotation.Nullable;
+
+import com.google.common.base.Supplier;
+
+/** A reference to an object which can carry an object alongside it. */
+public class ReferenceWithError<T> implements Supplier<T> {
+
+ private final T object;
+ private final Throwable error;
+ private final boolean throwErrorOnAccess;
+
+ /** returns a reference which includes an error, and where attempts to
get the content cause the error to throw */
+ public static <T> ReferenceWithError<T> newInstanceWithFatalError(T
object, Throwable error) {
+ return new ReferenceWithError<T>(object, error, true);
+ }
+
+ /** returns a reference which includes an error, but attempts to get
the content do not cause the error to throw */
+ public static <T> ReferenceWithError<T>
newInstanceWithInformativeError(T object, Throwable error) {
--- End diff --
From the method name, I didn't guess that the error would not
`throwsErrorOnAccess`. Perhaps `newInstanceWithInformativeWarning` would be
better (but that doesn't fit nicely with `getError`)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
