Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/94#discussion_r15809988
--- Diff:
software/webapp/src/main/java/brooklyn/entity/webapp/JavaWebAppSoftwareProcessImpl.java
---
@@ -178,33 +176,4 @@ protected void doStop() {
setAttribute(REQUESTS_PER_SECOND_LAST, 0D);
setAttribute(REQUESTS_PER_SECOND_IN_WINDOW, 0D);
}
-
- protected Set<String> getEnabledProtocols() {
- return getAttribute(JavaWebAppSoftwareProcess.ENABLED_PROTOCOLS);
- }
-
- protected boolean isProtocolEnabled(String protocol) {
- for (String contender : getEnabledProtocols()) {
- if (protocol.equalsIgnoreCase(contender)) {
- return true;
- }
- }
- return false;
- }
-
- protected String inferBrooklynAccessibleRootUrl() {
--- End diff --
Agree to moving this code to somewhere that's not java specific (i.e. not
in `JavaWebAppSoftwareProcessImpl`). However, we should probably deprecate this
method and delete after releasing 0.7.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
