Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/94#discussion_r15810535
--- Diff:
software/webapp/src/main/java/brooklyn/entity/webapp/nodejs/NodeJsWebAppSshDriver.java
---
@@ -0,0 +1,161 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package brooklyn.entity.webapp.nodejs;
+
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import brooklyn.entity.basic.AbstractSoftwareProcessSshDriver;
+import brooklyn.entity.basic.Attributes;
+import brooklyn.entity.basic.SoftwareProcess;
+import brooklyn.entity.webapp.WebAppService;
+import brooklyn.location.basic.SshMachineLocation;
+import brooklyn.util.collections.MutableList;
+import brooklyn.util.collections.MutableMap;
+import brooklyn.util.file.ArchiveUtils;
+import brooklyn.util.os.Os;
+import brooklyn.util.ssh.BashCommands;
+import brooklyn.util.text.Strings;
+
+import com.google.common.base.Joiner;
+import com.google.common.collect.ImmutableMap;
+import com.google.common.collect.ImmutableSet;
+import com.google.common.collect.Iterables;
+import com.google.common.collect.Lists;
+
+public class NodeJsWebAppSshDriver extends
AbstractSoftwareProcessSshDriver implements NodeJsWebAppDriver {
+
+ private static final Logger LOG =
LoggerFactory.getLogger(NodeJsWebAppService.class);
+
+ public NodeJsWebAppSshDriver(NodeJsWebAppServiceImpl entity,
SshMachineLocation machine) {
+ super(entity, machine);
+ }
+
+ public NodeJsWebAppServiceImpl getEntity() {
+ return (NodeJsWebAppServiceImpl) super.getEntity();
+ }
+
+ @Override
+ public Integer getHttpPort() {
+ return getEntity().getAttribute(Attributes.HTTP_PORT);
+ }
+
+ @Override
+ public void postLaunch() {
+ String rootUrl = String.format("http://%s:%d/";, getHostname(),
getHttpPort());
+ entity.setAttribute(WebAppService.ROOT_URL, rootUrl);
+ }
+
+ protected Map<String, Integer> getPortMap() {
+ return ImmutableMap.of("http",
getEntity().getAttribute(WebAppService.HTTP_PORT));
+ }
+
+ @Override
+ public Set<Integer> getPortsUsed() {
+ return ImmutableSet.<Integer>builder()
+ .addAll(super.getPortsUsed())
+ .addAll(getPortMap().values())
+ .build();
+ }
+
+ @Override
+ public void install() {
+ List<String> packages =
getEntity().getConfig(NodeJsWebAppService.NODE_PACKAGE_LIST);
+ LOG.info("Installing Node.JS {} {}",
getEntity().getConfig(SoftwareProcess.SUGGESTED_VERSION),
Iterables.toString(packages));
+
+ List<String> commands = MutableList.<String>builder()
+ .add(BashCommands.INSTALL_CURL)
+ .add(BashCommands.ifExecutableElse0("apt-get",
BashCommands.chain(
+
BashCommands.installPackage("python-software-properties python g++ make"),
+ BashCommands.sudo("add-apt-repository
ppa:chris-lea/node.js"))))
+ .add(BashCommands.installPackage(MutableMap.of("yum", "git
nodejs npm", "apt", "git-core nodejs"), null))
+ .add(BashCommands.sudo("npm install -g n"))
+ .add(BashCommands.sudo("n " +
getEntity().getConfig(SoftwareProcess.SUGGESTED_VERSION)))
+ .build();
+
+ if (packages != null && packages.size() > 0) {
+ commands.add(BashCommands.sudo("npm install -g " + Joiner.on('
').join(packages)));
+ }
+
+ newScript(INSTALLING)
+ .body.append(commands)
+ .execute();
+ }
+
+ @Override
+ public void customize() {
+ List<String> commands = Lists.newLinkedList();
+
+ String gitRepoUrl =
getEntity().getConfig(NodeJsWebAppService.APP_GIT_REPOSITORY_URL);
+ String archiveUrl =
getEntity().getConfig(NodeJsWebAppService.APP_ARCHIVE_URL);
+ String appName =
getEntity().getConfig(NodeJsWebAppService.APP_NAME);
+
+ if (Strings.isNonBlank(gitRepoUrl) &&
Strings.isNonBlank(archiveUrl)) {
+ throw new IllegalStateException("Only one of Git or archive
URL must be set");
--- End diff --
Include which entity this is in the exception (and also what the gitRepoUrl
and archiveUrl are). e.g.
throw new IllegalStateException("Only one of Git or archive URL must be
set for "+entity+"; got repo "+gitRepoUrl+" and archive "+archiveUrl);
Same for other exception thrown below.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
