[
https://issues.apache.org/jira/browse/BROOKLYN-12?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14086233#comment-14086233
]
ASF GitHub Bot commented on BROOKLYN-12:
----------------------------------------
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/94#discussion_r15810286
--- Diff:
software/webapp/src/main/java/brooklyn/entity/webapp/JavaWebAppSoftwareProcessImpl.java
---
@@ -178,33 +176,4 @@ protected void doStop() {
setAttribute(REQUESTS_PER_SECOND_LAST, 0D);
setAttribute(REQUESTS_PER_SECOND_IN_WINDOW, 0D);
}
-
- protected Set<String> getEnabledProtocols() {
- return getAttribute(JavaWebAppSoftwareProcess.ENABLED_PROTOCOLS);
- }
-
- protected boolean isProtocolEnabled(String protocol) {
- for (String contender : getEnabledProtocols()) {
- if (protocol.equalsIgnoreCase(contender)) {
- return true;
- }
- }
- return false;
- }
-
- protected String inferBrooklynAccessibleRootUrl() {
--- End diff --
Did nothing use this method?!
Should we change things like:
HostAndPort accessible =
BrooklynAccessUtils.getBrooklynAccessibleAddress(this, getAttribute(HTTP_PORT));
String nodeJsUrl = String.format("http://%s:%d";,
accessible.getHostText(), accessible.getPort());
to use it instead, or should we deprecate it and go with the pattern used
elsewhere?
> Add Node.JS application support
> -------------------------------
>
> Key: BROOKLYN-12
> URL: https://issues.apache.org/jira/browse/BROOKLYN-12
> Project: Brooklyn
> Issue Type: New Feature
> Environment: Linux
> Reporter: Andrew Kennedy
> Assignee: Andrew Kennedy
>
> Create entities and blueprints to deploy and manage Node.JS applications and
> clustered services.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
