[ 
https://issues.apache.org/jira/browse/BROOKLYN-12?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14086250#comment-14086250
 ] 

ASF GitHub Bot commented on BROOKLYN-12:
----------------------------------------

Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/94#discussion_r15810863
  
    --- Diff: 
software/webapp/src/test/java/brooklyn/entity/webapp/nodejs/NodeJsWebAppFixtureIntegrationTest.java
 ---
    @@ -0,0 +1,62 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package brooklyn.entity.webapp.nodejs;
    +
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +import org.testng.annotations.DataProvider;
    +
    +import brooklyn.entity.basic.SoftwareProcess;
    +import brooklyn.entity.proxying.EntitySpec;
    +import brooklyn.entity.webapp.AbstractWebAppFixtureIntegrationTest;
    +import brooklyn.entity.webapp.WebAppService;
    +import brooklyn.location.basic.PortRanges;
    +import brooklyn.test.entity.TestApplication;
    +
    +public class NodeJsWebAppFixtureIntegrationTest extends 
AbstractWebAppFixtureIntegrationTest {
    +
    +    private static final Logger LOG = 
LoggerFactory.getLogger(NodeJsWebAppFixtureIntegrationTest.class);
    +
    +    public static final String GIT_REPO_URL = 
"https://github.com/grkvlt/node-hello-world.git";;
    --- End diff --
    
    Do you think we should move this so it's not owned by an individual? No 
strong feelings as it's only used by a test. But if it ever gets into a 
tutorial then we should move it into something like 
`github:brooklyncentral/node-hello-world.git`



> Add Node.JS application support
> -------------------------------
>
>                 Key: BROOKLYN-12
>                 URL: https://issues.apache.org/jira/browse/BROOKLYN-12
>             Project: Brooklyn
>          Issue Type: New Feature
>         Environment: Linux
>            Reporter: Andrew Kennedy
>            Assignee: Andrew Kennedy
>
> Create entities and blueprints to deploy and manage Node.JS applications and 
> clustered services.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to