Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/94#issuecomment-51203300
Code looks good; just minor comments.
However, the live test `NodeJsWebAppSoftlayerLiveTest.test_Ubuntu_12_0_4`
failed for me. I got the error below. No idea why `ps -p` would be complaining,
as it looks like it should have populated the pid file. The test terminated the
VM so I haven't investigated further.
2014-08-05 14:57:58,570 DEBUG brooklyn.SSH
[brooklyn-execmanager-m55tvPWd-10]: launching
NodeJsWebAppServiceImpl{id=J0xgqOS2}, initiating ssh on machine
SshMachineLocation[119.81.168.42:119.81.168.42/119.81.168.42] (env
{PORT=8080}): export
RUN_DIR="/home/users/aled/brooklyn-managed-processes/apps/mU7cP0SC/entities/NodeJsWebAppService_J0xgqOS2"
; mkdir -p $RUN_DIR ; cd $RUN_DIR ; cd
/home/users/aled/brooklyn-managed-processes/apps/mU7cP0SC/entities/NodeJsWebAppService_J0xgqOS2/node-hello-world
; ( if test "$UID" -eq 0; then ( nohup node app.js & ); else echo "nohup node
app.js &" | sudo -E -n -S -s -- bash ; fi ) ; echo $! >
/home/users/aled/brooklyn-managed-processes/apps/mU7cP0SC/entities/NodeJsWebAppService_J0xgqOS2/pid.txt
2014-08-05 14:58:04,574 DEBUG brooklyn.SSH [Thread-32]:
[[email protected]:stdout] Executed
/tmp/brooklyn-20140805-145758571-jaxX-launching_NodeJsWebAppServiceI.sh, result 0
2014-08-05 14:58:05,527 DEBUG brooklyn.SSH
[brooklyn-execmanager-m55tvPWd-8]: check-running
NodeJsWebAppServiceImpl{id=J0xgqOS2}, initiating ssh on machine
SshMachineLocation[119.81.168.42:119.81.168.42/119.81.168.42] (env
{PORT=8080}): export
RUN_DIR="/home/users/aled/brooklyn-managed-processes/apps/mU7cP0SC/entities/NodeJsWebAppService_J0xgqOS2"
; mkdir -p $RUN_DIR ; cd $RUN_DIR ; test -f
/home/users/aled/brooklyn-managed-processes/apps/mU7cP0SC/entities/NodeJsWebAppService_J0xgqOS2/pid.txt
|| exit 1 ; ps -p `cat
/home/users/aled/brooklyn-managed-processes/apps/mU7cP0SC/entities/NodeJsWebAppService_J0xgqOS2/pid.txt`
2014-08-05 14:58:12,723 DEBUG brooklyn.SSH [Thread-38]:
[[email protected]:stderr] ERROR: List of process IDs must follow -p.
2014-08-05 14:58:12,723 DEBUG brooklyn.SSH [Thread-38]:
[[email protected]:stderr] ********* simple selection ********* *********
selection by list *********
2014-08-05 14:58:12,723 DEBUG brooklyn.SSH [Thread-38]:
[[email protected]:stderr] -A all processes -C by
command name
2014-08-05 14:58:12,723 DEBUG brooklyn.SSH [Thread-38]:
[[email protected]:stderr] -N negate selection -G by
real group ID (supports names)
2014-08-05 14:58:12,723 DEBUG brooklyn.SSH [Thread-38]:
[[email protected]:stderr] -a all w/ tty except session leaders -U by
real user ID (supports names)
2014-08-05 14:58:12,723 DEBUG brooklyn.SSH [Thread-38]:
[[email protected]:stderr] -d all except session leaders -g by
session OR by effective group name
2014-08-05 14:58:12,723 DEBUG brooklyn.SSH [Thread-38]:
[[email protected]:stderr] -e all processes -p by
process ID
2014-08-05 14:58:12,723 DEBUG brooklyn.SSH [Thread-38]:
[[email protected]:stderr] T all processes on this terminal -s
processes in the sessions given
2014-08-05 14:58:12,723 DEBUG brooklyn.SSH [Thread-38]:
[[email protected]:stderr] a all w/ tty, including other users -t by tty
2014-08-05 14:58:12,723 DEBUG brooklyn.SSH [Thread-38]:
[[email protected]:stderr] g OBSOLETE -- DO NOT USE -u by
effective user ID (supports names)
2014-08-05 14:58:12,724 DEBUG brooklyn.SSH [Thread-38]:
[[email protected]:stderr] r only running processes U
processes for specified users
2014-08-05 14:58:12,724 DEBUG brooklyn.SSH [Thread-38]:
[[email protected]:stderr] x processes w/o controlling ttys t by tty
2014-08-05 14:58:12,724 DEBUG brooklyn.SSH [Thread-38]:
[[email protected]:stderr] *********** output format **********
*********** long options ***********
2014-08-05 14:58:12,724 DEBUG brooklyn.SSH [Thread-38]:
[[email protected]:stderr] -o,o user-defined -f full --Group
--User --pid --cols --ppid
2014-08-05 14:58:12,724 DEBUG brooklyn.SSH [Thread-38]:
[[email protected]:stderr] -j,j job control s signal --group
--user --sid --rows --info
2014-08-05 14:58:13,069 DEBUG brooklyn.SSH [Thread-38]:
[[email protected]:stderr] -O,O preloaded -o v virtual memory
--cumulative --format --deselect
2014-08-05 14:58:13,069 DEBUG brooklyn.SSH [Thread-37]:
[[email protected]:stdout] Executed
/tmp/brooklyn-20140805-145808397-X4DC-check-running_NodeJsWebAppServ.sh, result
1
2014-08-05 14:58:13,069 DEBUG brooklyn.SSH [Thread-38]:
[[email protected]:stderr] -l,l long u user-oriented --sort
--tty --forest --version
2014-08-05 14:58:13,070 DEBUG brooklyn.SSH [Thread-38]:
[[email protected]:stderr] -F extra full X registers --heading
--no-heading --context
2014-08-05 14:58:13,070 DEBUG brooklyn.SSH
[brooklyn-execmanager-m55tvPWd-8]: check-running
NodeJsWebAppServiceImpl{id=J0xgqOS2}, on machine
SshMachineLocation[119.81.168.42:119.81.168.42/119.81.168.42], completed:
return status 1
2014-08-05 14:58:13,071 DEBUG brooklyn.SSH [Thread-38]:
[[email protected]:stderr] ********* misc options
*********
2014-08-05 14:58:13,071 DEBUG brooklyn.SSH [Thread-38]:
[[email protected]:stderr] -V,V show version L list format codes f
ASCII art forest
2014-08-05 14:58:13,071 DEBUG brooklyn.SSH [Thread-38]:
[[email protected]:stderr] -m,m,-L,-T,H threads S children in sum
-y change -l format
2014-08-05 14:58:13,071 DEBUG brooklyn.SSH [Thread-38]:
[[email protected]:stderr] -M,Z security data c true command name
-c scheduling class
2014-08-05 14:58:13,071 DEBUG brooklyn.SSH [Thread-38]:
[[email protected]:stderr] -w,w wide output n numeric WCHAN,UID
-H process hierarchy
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
