[
https://issues.apache.org/jira/browse/BROOKLYN-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14131292#comment-14131292
]
ASF GitHub Bot commented on BROOKLYN-36:
----------------------------------------
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/62#discussion_r17469190
--- Diff:
utils/common/src/main/java/brooklyn/util/ssh/IptablesCommands.java ---
@@ -87,15 +89,20 @@ public static String iptablesServiceStatus() {
}
/**
- * Returns the command that saves on disk iptables rules, to make them
resilient to reboot.
+ * Returns the command that saves iptables rules on file.
+ *
+ * @return Returns the command that saves iptables rules on file.
*
- * @return Returns the command that saves on disk iptables rules.
*/
public static String saveIptablesRules() {
- return BashCommands.alternatives(
- BashCommands.ifExecutableElse1("iptables-save",
sudo("iptables-save")),
- iptablesService("save"));
- }
+ return alternatives(sudo("service iptables save"),
installPackage("iptables-persistent"));
+ }
+ /*
--- End diff --
Strange to have this commented out code here. Either delete, or if it's
worth keeping then it needs to go inside the relevant method, and it needs a
comment to say why it could be useful in the future and why it's not being used
now.
> IptablesCommands.saveIptablesRules doesn't work as expected
> -----------------------------------------------------------
>
> Key: BROOKLYN-36
> URL: https://issues.apache.org/jira/browse/BROOKLYN-36
> Project: Brooklyn
> Issue Type: Bug
> Reporter: Andrea Turli
> Assignee: Andrea Turli
> Priority: Minor
> Fix For: 0.7.0-SNAPSHOT
>
>
> This needs to be revisited as the behavior is not as described at
> http://www.thomas-krenn.com/en/wiki/Saving_Iptables_Firewall_Rules_Permanently,
> for example
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
